chore: bump clap to v4.2.4 for v1.69 clippy lints #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchmindtree
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Also worth noting that the formatting of the output with clap v4 is a little different! I think I like the new output a little more - seems a little more straight-forward / less opinionated?
We might want to update our EXAMPLES section to better match the new formatting, but I'm not sure we can bold and underline using the current approach. We can handle this in a follow-up anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details can be seen from clap-rs/clap#4733. Basically, using Subcommand with old clap versions causes clippy 1.69 to complain. This PR switches to the latest clap version to get the upstream fix.