feat: expose cli functionality as a lib #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
force-pushed
the
kayagokalp/forc-wallet-lib
branch
from
f8e381d
to
3180010
Compare
|
Waiting for #110. |
mitchmindtree
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Nice one! utACK
Perhaps if we plan to expose more parts in a follow-up PR, it might make sense to do so alongside a draft PR at the Sway repo that introduces the forc-wallet crate as a dependency for the forc-client crate? I'm thinking this might help to more clearly guide what we actually need to expose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #100.
In a recent tooling sync we talked about splitting lib functionality of
forc-walletinto two parts:This completes the first part, any
forc-walletcommand that is useable from CLI should also be useable consumingforc-walletas lib with this PR.