React v18 upgrade #172
Merged
React v18 upgrade #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmoschini
force-pushed
the
react-v18-upgrade
branch
from
63d922f
to
c12f003
Compare
See https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html Also software-mansion/react-native-svg#1741 (comment) related to conflicted versions of @types/react
andresmoschini
force-pushed
the
react-v18-upgrade
branch
from
c12f003
to
786771a
Compare
andresmoschini
added a commit
that referenced
this pull request
Apr 20, 2022
fix: revert Merge pull request #172 from FromDoppler/react-v18-upgrade and other updates
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team!
These are the required changes to upgrade to React v18.
I followed this guide, and the changes were minimal.
I had an issue with the types, and I fixed it following this comment.
Then, I found that React-Query v3 is not compatible with React v18, so I have upgraded to React-Query v4 Beta. I think that we can live with it because we are still not in production. But it is arguable.
The instructions to upgrade from React-Query v3 to v4 are also minimal, and they do not affect ow code.
What do you think? should we upgrade to React v18 now with these changes or should we wait?