Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use React 18 createRoot #22

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Use React 18 createRoot #22

merged 1 commit into from
Apr 14, 2022

Conversation

andresmoschini
Copy link
Member

Hi team!

We already created this project with React 18, but only partially because of it:

createRoot: New method to create a root to render or unmount. Use it instead of ReactDOM.render. New features in React 18 don’t work without it.

We are not taking advantage of the new features, but I think that it is better to be ready now to avoid difficult migrations in the future.

@andresmoschini
Copy link
Member Author

Related to FromDoppler/doppler-editors-webapp#172

Copy link
Contributor

@bseguermaking bseguermaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andresmoschini andresmoschini merged commit f617db4 into main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants