- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate code coverage on PHP 8 #5689
Conversation
.github/workflows/ci.yml
Outdated
@@ -37,9 +37,6 @@ jobs: | |||
|
|||
- operating-system: 'ubuntu-20.04' | |||
php-version: '7.4' | |||
job-description: 'with calculating code coverage' | |||
calculate-code-coverage: 'yes' | |||
phpunit-flags: '--testsuite coverage --exclude-group covers-nothing --coverage-clover build/logs/clover.xml' | |||
|
|||
- operating-system: 'ubuntu-20.04' | |||
php-version: '7.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
php-version: '7.4' | |
php-version: '8.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same few lines later for job-description: 'with migration rules'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SRP, let's do code coverage PHP version update here and handle others in separate PR (as some syntax is broken with migration in PHP 8 and tests are failing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then drop the duplicated 7.4 job, we don't need 2 of them anymore
@@ -53,7 +47,9 @@ jobs: | |||
|
|||
- operating-system: 'ubuntu-20.04' | |||
php-version: '8.0' | |||
composer-flags: '--ignore-platform-req=php' # as this is a version not yet officially supported by PHP CS Fixer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder, maybe we should add 8.1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like a good idea... for separate PR ;)
Thank you @kubawerlos. |
It's almost a half a year since the release, we can use PHP 8 to calculate code coverage e.g. to avoid situation like in #5685 where it shows that coverage dropped.