Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #1645: FDBRecordContext::newRunner drops property storage #1646

Merged
merged 1 commit into from May 5, 2022
Merged

Resolves #1645: FDBRecordContext::newRunner drops property storage #1646

merged 1 commit into from May 5, 2022

Conversation

tian-yizuo
Copy link
Contributor

No description provided.

alecgrieser
alecgrieser requested changes May 5, 2022
View reviewed changes
Copy link
Contributor

@alecgrieser alecgrieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor javadoc suggestion

...core/src/main/java/com/apple/foundationdb/record/provider/foundationdb/FDBRecordContext.java Show resolved Hide resolved
@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-record-layer-pr-proto2
  • Commit ID: 7487a6c
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-record-layer-pr-proto3
  • Commit ID: 7487a6c
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@alecgrieser alecgrieser linked an issue May 5, 2022 that may be closed by this pull request
FDBRecordContext::newRunner drops property storage #1645
Closed
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-record-layer-pr-proto3
  • Commit ID: fc29c80
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: fdb-record-layer-pr-proto2
  • Commit ID: fc29c80
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@tian-yizuo tian-yizuo merged commit 318285f into FoundationDB:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecgrieser alecgrieser alecgrieser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FDBRecordContext::newRunner drops property storage
3 participants
@tian-yizuo @foundationdb-ci @alecgrieser