Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDBRecordContext::newRunner drops property storage #1645

Closed
alecgrieser opened this issue May 5, 2022 · 0 comments · Fixed by #1646
Closed

FDBRecordContext::newRunner drops property storage #1645

alecgrieser opened this issue May 5, 2022 · 0 comments · Fixed by #1646
Labels
bug Something isn't working

Comments

@alecgrieser
Copy link
Contributor

The method FDBRecordContext::newRunner creates a new FDBDatabaseRunner from an existing FDBRecordContext that is supposed to copy over the configuration from the first transaction (things like the priority, the weak-read semantics, the MDC context, the timer, etc.) so that each new transaction inherits those values from the base transaction. It appears that the RecordLayerPropertyStorage field is being dropped, though, so any of those configuration values aren't being passed in. See:

public FDBDatabaseRunner newRunner() {
FDBDatabaseRunner runner = database.newRunner();
runner.setTimer(timer);
runner.setMdcContext(getMdcContext());
runner.setWeakReadSemantics(weakReadSemantics);
runner.setPriority(priority);
runner.setTransactionTimeoutMillis(timeoutMillis);
return runner;
}

@alecgrieser alecgrieser added the bug Something isn't working label May 5, 2022
tian-yizuo added a commit to tian-yizuo/fdb-record-layer that referenced this issue May 5, 2022
tian-yizuo added a commit to tian-yizuo/fdb-record-layer that referenced this issue May 5, 2022
tian-yizuo added a commit that referenced this issue May 5, 2022
Resolves #1645: FDBRecordContext::newRunner drops property storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant