Feat/jimmy test cookies #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it consistent with the other methods in the context and possibly makes it easier to mock in tests.
UserService should only handle operations done on the User entity. Logout doesn't do any such operations and should thus belong in the resolver (i.e. controller).
Context should be handled in the resolver/controller layer.
The ServerContext interface should be agnostic about implementation details of how JWTs are set and cleared.
Doing this modularizes the express server to be used by supertest.
Since we are working with supertest, which is a bit lower-level than the previous testClient hook from Apollo-Server-Testing, the query method now takes in the GraphQL DocumentNode directly, converted to string using graphql's `print` method. The raw response now includes http headers, and the actual data is now in a JSON string, so we must parse it to achieve what testClient was previously doing for us.
We no longer need to mock/hardcode setting of cookies etc since our tests now actually use an express server, which handles these things.
We need to parse the `set-cookie` header in the raw response in our cookies tests.
clairefro
reviewed
Sep 14, 2020
There was a problem hiding this comment.
Looks really good and works. One question - are we still mocking the db on queries (not actually making calls)? I can see testClient is an instance of supertest but it looks like its test app argument is built with the same express server context as normal development server. I might not be understanding correctly
|
No, we are actually not mocking anything at the moment. Our index.ts takes |
clairefro
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current tests use the apollo-server-testing library which provides a
queryandmutationhook against theApolloServerdirectly without going through HTTP. However, this library sucks (see apollographql/apollo-server#2277), and doesn't handle cookies at all. For thorough testing of routes that set cookies, we need to test whether cookies are set properly.The goal for this branch is to instead instantiate the express server loaded with app (i.e.
app) and use the supertest library to run.postagainst the express server. Similarly, this framework doesn't require an http service to be started.supertestinstead ofapollo-server-testing