Try resolve #193: exclude refs to shaded modules #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjfanning So basically, would this help avoid the issue? |
|
seems to fix the broken test runs in POI - I'm running som extra tests - I'll get back when they complete the JPM stuff is really hard to get right and harder to test |
|
the test run completed - seems like this might help - I hope it doesn't break something else - but so hard to know |
|
@pjfanning Ok thanks! I think I should just go ahead and merge this, push a release. It's the only accumulated 6.6 change and if module stuff is not working it can't break worse (.. I hope). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
providesstatements from module definition; hoping this resolves #193.