Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module com.ctc.wstx does not read a module that exports com.ctc.wstx.shaded.msv.org_isorelax.verifier #193

Closed
agavrilov76 opened this issue Jan 22, 2024 · 6 comments · Fixed by #198
Milestone

Comments

@agavrilov76
Copy link

I'm getting the following error when running under JPMS (Java Modules) after upgrading 6.6.0

Error occurred during initialization of boot layer
java.lang.module.ResolutionException: Module com.ctc.wstx does not read a module that exports com.ctc.wstx.shaded.msv.org_isorelax.verifier
@cowtowncoder
Copy link
Member

Hmmh. relaxngDatatype is included as shaded artifact, not as dependency. So I don't think there should be any module dependency. But I don't know what needs to change in module definition, generated using Modirect from

src/moditect/module-info.java

This shouldn't have changed since 6.5.x; the only change that seems at all relevant is #182 (dependency update for msv-core).

So, I am not sure how to proceed here. All help would be appreciated!

@pjfanning
Copy link
Member

This error occurred in Apache POI too. I had to revert the upgrade of woodstox.

@cowtowncoder
Copy link
Member

cowtowncoder commented Feb 26, 2024

It'd be good to resolve this, but I really do not know what change is needed: possibly the 4th and/or 5th provides clause from end of src/moditect/module-info.java that refers to shaded Factory/Factory loader. But it'd be good to have someone who could test it with a local build.

@pjfanning Do you think you could try this by just removing 2 entries after "//Include shaded in provisions", doing local build and trying resulting snapshot version?
If that works, I could release 6.6.1 with just that change.

EDIT: Created #198 as possible solution as per ^^^

@cowtowncoder cowtowncoder changed the title Module com.ctc.wstx does not read a module that exports com.ctc.wstx.shaded.msv.org_isorelax.verifier Module com.ctc.wstx does not read a module that exports com.ctc.wstx.shaded.msv.org_isorelax.verifier Feb 26, 2024
@cowtowncoder cowtowncoder modified the milestones: 4.2.1, 6.6.1 Feb 26, 2024
@pjfanning
Copy link
Member

@cowtowncoder the POI build worked ok with the 6.6.1 release - thanks

@cowtowncoder
Copy link
Member

@pjfanning Thank you for confirming!

@cowtowncoder
Copy link
Member

Would #200 be related here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants