Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SM64] Move into the new folders for settings rework #324

Merged
merged 5 commits into from
May 24, 2024
Merged

[SM64] Move into the new folders for settings rework #324

merged 5 commits into from
May 24, 2024

Conversation

Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Apr 6, 2024

Suggested by dragon421 to make reviewing easier

@Lilaa3 Lilaa3 marked this pull request as ready for review April 6, 2024 17:36
@Lilaa3 Lilaa3 mentioned this pull request Apr 6, 2024
Open
jesusyoshi54
jesusyoshi54 approved these changes May 11, 2024
View reviewed changes
Copy link
Collaborator

@jesusyoshi54 jesusyoshi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense and it exported a level and Mario.

@jesusyoshi54 jesusyoshi54 added the merge soon Will be merged in a few days at most if nothing else comes up label May 11, 2024
@Dragorn421 Dragorn421 added this to the v2.2.2 milestone May 20, 2024
Dragorn421
Dragorn421 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem to break oot
Merge for next version

@Dragorn421 Dragorn421 merged commit 0434299 into Fast-64:main May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dragorn421 Dragorn421 Dragorn421 approved these changes

@jesusyoshi54 jesusyoshi54 jesusyoshi54 approved these changes

Assignees
No one assigned
Labels
merge soon Will be merged in a few days at most if nothing else comes up
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lilaa3 @Dragorn421 @jesusyoshi54