Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OoT] Fix for issue #293 #294

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Yanis42
Copy link
Contributor

@Yanis42 Yanis42 commented Jan 15, 2024

I tried to find a solution that didn't involve an extra loop but couldn't find something better 馃し

@Yanis42 Yanis42 added the oot Has to do with the Ocarina of Time 64 side label Jan 15, 2024
@Dragorn421
Copy link
Contributor

I don't think this fixes the corner case where you do have a mesh object but it has no geometry

Also apparently fast64 already tries to check this elsewhere, see this screenshot (using fast64 version not-this-PR) where I try to export a room with a mesh that has no face but does have vertices:
image

@Yanis42
Copy link
Contributor Author

Yanis42 commented Jan 15, 2024

another way do to this would be checking if the BoundingBox members are still None

@Dragorn421 Dragorn421 added the waiting for author Waiting for the author to answer questions, do changes, ... label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oot Has to do with the Ocarina of Time 64 side waiting for author Waiting for the author to answer questions, do changes, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants