[OoT] Auto-set tied Room object for transition actors and entrances #288
Conversation
|
(marked a ready since I enjoy this solution) |
Yanis42
changed the title
fromRoom to the parented room is it's parented to a room
| if scene.gameEditorMode != "OOT": | ||
| return | ||
|
|
||
| def updateTiedRoom(parentObj: Object, isScene: bool): |
There was a problem hiding this comment.
please don't use the same function name twice
There was a problem hiding this comment.
oops lol didn't notice that
| if parentObj.ootEmptyType == "Room": | ||
| updateTiedRoom(parentObj, False) | ||
| elif parentObj.ootEmptyType == "Scene": | ||
| updateTiedRoom(parentObj, True) |
There was a problem hiding this comment.
since you use children_recursive, empties will be processed twice, once per scene and once per room (they're recursively children of both)
depending on who comes first between scene and rooms, the final result will be different, which doesn't sound intended
this updates automatically the "tiedRoom" prop (or "fromRoom" and "toRoom" for doors), it's to avoid people updating this manually, for instance for waterboxes it would set the room to none if it becomes parented to the scene empty and vice versa, this idea was something cdi asked: "Would it be possible to still have the shorthand method of having the "from" room be auto assigned if it happens to be parented to a room object?" (https://discord.com/channels/874816709855440926/874832163483287612/1194365695841013923), which lead to this PR (and the similar ones) |
This is a feature request I tried to implement, it's not great and the main limitation is the active object requirement, too bad you can't set default values for
PointerProperty...This is a draft until I find a solution I'm happy with, feel free to make suggestions