Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OOT] Actor Collider Import/Export #209

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kurethedead
Copy link
Collaborator

@kurethedead kurethedead commented Jan 10, 2023

This PR allows for importing/exporting actor colliders as a part of the skeleton/DL import/export process. The bulk of this was done a while ago but I never got around to finishing it, mainly because I didn't have the time to figure out how to test exports more extensively with custom actors. There's a couple things I'd like some feedback on:

  1. Naming conventions for some of the physics properties (AC, AT, OC), also general UI layout for these properties.
  2. The current setup for joint sphere colliders uses the skeleton to store shared collision properties, so only one joint sphere group is allowed per skeleton. I'm not sure if there's a better solution to this other than providing options to import specific named colliders. Right now only the first joint sphere group is imported.
  3. I'm not sure how Ganon2's joint sphere colliders work. I can't seem to import them in a way that looks correct, but the code I wrote otherwise seems to work on other actors.

There's some other minor issues I added to the README but those can be handled manually by the user IMO.

@MNGoldenEagle
Copy link

Could we add a checkbox that enables exporting the vertices for a quad collider for custom actors? It probably isn't needed for most actors, but there could be some custom actors that want to use the collider vertices instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants