Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pewpew -d crash #99

Merged
merged 6 commits into from
Sep 9, 2022
Merged

pewpew -d crash #99

merged 6 commits into from
Sep 9, 2022

Commits on Sep 8, 2022

  1. Fixed an issue with out directories and stats file params 

    - new versions of Clap panic with invalid utf8 passed to value_of_os()
  - clap-rs/clap#3344
    @tkmcmaster
    tkmcmaster committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    93346a3 View commit details
    Browse the repository at this point in the history

  2. Added comments to changes

    @tkmcmaster
    tkmcmaster committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    b2793d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Added tests for the command line parser 

    - Split the parsing code into separate functions that can be tested
- Moved the logger init out of the match functions so we can test the cli parsing
- Added tests around the path checks. Found we weren't parsing the try -d the same and fixed it
    @tkmcmaster
    tkmcmaster committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    0e8433e View commit details
    Browse the repository at this point in the history

  2. Added additional tests for the cli parsing

    @tkmcmaster
    tkmcmaster committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    f4ed6a6 View commit details
    Browse the repository at this point in the history

  3. Cleaned up the cli tests

    @tkmcmaster
    tkmcmaster committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    92db2d2 View commit details
    Browse the repository at this point in the history

  4. Updated the cargo deny.toml 

    - Unicode license is allowed under our current whitelist
- Ignoring the time advisory since chrono should not be impacted. chronotope/chrono#602
    @tkmcmaster
    tkmcmaster committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    ddd8206 View commit details
    Browse the repository at this point in the history