Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pewpew -d crash #99

Merged
merged 6 commits into from Sep 9, 2022
Merged

pewpew -d crash #99

merged 6 commits into from Sep 9, 2022

Conversation

tkmcmaster
Copy link
Contributor

@tkmcmaster tkmcmaster commented Sep 9, 2022

- new versions of Clap panic with invalid utf8 passed to value_of_os()
  - clap-rs/clap#3344
- Split the parsing code into separate functions that can be tested
- Moved the logger init out of the match functions so we can test the cli parsing
- Added tests around the path checks. Found we weren't parsing the try -d the same and fixed it
@tkmcmaster tkmcmaster requested a review from a team September 9, 2022 15:53
@tkmcmaster tkmcmaster self-assigned this Sep 9, 2022
- Unicode license is allowed under our current whitelist
- Ignoring the time advisory since chrono should not be impacted. chronotope/chrono#602
@tkmcmaster tkmcmaster merged commit af9568a into master Sep 9, 2022
@tkmcmaster tkmcmaster deleted the dashDCrash branch September 9, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants