-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: New chat aren't showing bold in Left Hand Nav #6898
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! cc @parasharrajat
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Merging it and applying the |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @aswin-s and waiting for review I was on vacation. This looks good.
Could you please add videos for all platforms and present the following features;
- The current issue.
- Unread Message when the app is put to foreground from background.
@@ -134,7 +135,8 @@ class Expensify extends PureComponent { | |||
} | |||
|
|||
componentWillUnmount() { | |||
AppState.removeEventListener('change', this.initializeClient); | |||
if (!this.appStateChangeListener) { return; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please expand this to multiple lines?
if (!this.appStateChangeListener) { return; } | |
if (!this.appStateChangeListener) { | |
return; | |
} |
@@ -85,6 +85,7 @@ class Expensify extends PureComponent { | |||
ActiveClientManager.init(); | |||
this.setNavigationReady = this.setNavigationReady.bind(this); | |||
this.initializeClient = this.initializeClient.bind(true); | |||
this.appStateChangeListener = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.appStateChangeListener = null; |
@@ -106,6 +106,7 @@ class ReportActionsView extends React.Component { | |||
this.recordTimeToMeasureItemLayout = this.recordTimeToMeasureItemLayout.bind(this); | |||
this.loadMoreChats = this.loadMoreChats.bind(this); | |||
this.sortedReportActions = []; | |||
this.appStateChangeListener = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.appStateChangeListener = null; |
@parasharrajat Should I raise a follow up PR with the suggested changes? |
These changes are no blocker for me so If @marcochavezf says we should do these then yeah please add a follow-up? |
@parasharrajat Yeah, I think we could include these changes as a follow-up, thank you for doing it @aswin-s |
It looks like this change was made in react-native |
I think we need to either revert this PR or upgrade the whole app to RN |
@roryabraham as explained over here, removeEventListener was not working on react-native-web. I guess upgrading to 0.65 will solve it for both platforms, considering there is only a small diff between both versions. https://react-native-community.github.io/upgrade-helper/?from=0.64.1&to=0.65.0 Related to this, I would also like to point out that dependencies like WDYT? |
I suppose we should update react-native and the other dependencies that are throwing the error. I'll work on a pull request to upgrade RN. |
I have an upgrade PR here, but I could use help testing it. Works well on iOS from my testing so far. |
🚀 Deployed to staging by @marcochavezf in version: 1.1.23-2 🚀
|
🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀
|
Details
This PR fixes an issue where new chat messages were not being shown in bold inside LHN.
Fixed Issues
$ #6874
Tests
QA Steps
Tested On
Screenshots
Web
fix_unread.mp4
Mobile Web
N.A
Desktop
iOS
Android