Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the original dependency and switch it to URL module #249

Merged
merged 1 commit into from Mar 1, 2022
Merged

Remove the original dependency and switch it to URL module #249

merged 1 commit into from Mar 1, 2022

Conversation

AlexHladin
Copy link
Contributor

In the JS work available the URL class could easily substitute the original package.

Copy link
Contributor

@joeybaker joeybaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Makes a lot of sense. I'll let this sit for a bit to see if other maintainers want to weigh in.

@joeybaker
Copy link
Contributor

@AlexHladin ping me in a week or so if this hasn't merged!

@JRichlen
Copy link

JRichlen commented Feb 28, 2022

@AlexHladin @joeybaker Can this be merged and released? Trying to knock out some vulnerabilities picked up by a scanning tool. It found a high severity vulnerability (CVE-2022-0512) linked to url-parser in original. Merging this would eliminate that vulnerability from the transitive dependency (since it eliminates that dependency).

@AlexHladin
Copy link
Contributor Author

@AlexHladin Can this be merged? Trying to knock out some vulnerabilities picked up by a scanning tool. It found a high severity vulnerability linked to url-parser in original. Merging this would eliminate that vulnerability from the transitive dependency (since it eliminates that dependency).

Yes, this PR could be merged

@joeybaker joeybaker merged commit fa900cc into EventSource:master Mar 1, 2022
@otramony
Copy link

otramony commented Mar 2, 2022

Great! This will also help my team remove the CVE-2022-0691 critical vulnerability in url-parse from our reports. Is there an ETA for a release?

@joeybaker
Copy link
Contributor

v2 released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants