Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventSource v2.0.0 #3

Closed
ptweety opened this issue Mar 13, 2022 · 5 comments
Closed

EventSource v2.0.0 #3

ptweety opened this issue Mar 13, 2022 · 5 comments

Comments

@ptweety
Copy link

ptweety commented Mar 13, 2022

Hi @bartbutenaers,

there is a new version 2.0.0 of EventSource available. Since you have forked lib/eventsource.js I wonder if you need to update?

@bartbutenaers
Copy link
Owner

Hi @ptweety,
I don't see any release notes, so not sure what has changed. Mostly when the major version number changes, breaking changes are being introduced. Do you know what has changed?

I should have a look whether I can apply my fix somehow automatically to their cide. Then we can add their lib as a dependency here, so new versions are installed automatically...

Bart

@ptweety
Copy link
Author

ptweety commented Mar 13, 2022

Only thing I found was something in HISTORY.md:

https://github.com/EventSource/eventsource/blob/4579961e1e25c639829ce3c3253003d6c61cfc64/HISTORY.md?plain=1#L1-L5 :

2.0.0

@bartbutenaers
Copy link
Owner

@ptweety,
I have released a new version of this node (0.2.3), which supports EventSource version 2.0.0:

image

Please close this issue when it works as expected.

@bartbutenaers
Copy link
Owner

BTW it seemed not possible to fix the module automatically, so I again had to copy their js file and adapt it unfortunately...

@ptweety
Copy link
Author

ptweety commented Mar 14, 2022

Hi @bartbutenaers,
after some testing over night I can confirm a working environment and no issues on my side.
Thank you for your quick reaction and update of the node. ;)

@ptweety ptweety closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants