Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only parse url if it's a string #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

Only parse url if it's a string #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/eventsource.js
View file
Open in desktop
Expand Up @@ -87,7 +87,10 @@ function EventSource (url, eventSourceInitDict) {
var reconnectUrl = null

function connect () {
var options = parse(url)
var options = url
if (typeof url === 'string') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense; the spec does say that a URL record is acceptable. Would you mind added a test for this?

options = parse(url)
}
var isSecure = options.protocol === 'https:'
options.headers = { 'Cache-Control': 'no-cache', 'Accept': 'text/event-stream' }
if (lastEventId) options.headers['Last-Event-ID'] = lastEventId
Expand Down