New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only parse url if it's a string #154
base: master
Are you sure you want to change the base?
Conversation
The failure on node 4.x seems unrelated to my change
|
This simple PR is very helpful to have Unix Domain Socket support. Could anyone have an eye on it please? |
The force push is just a rebase with master |
ping @rexxars PTAL; looks like we're currently maintaining a fork because of this |
@rumpl could you do a rebase to trigger CI? |
@@ -81,7 +81,10 @@ function EventSource (url, eventSourceInitDict) { | |||
var reconnectUrl = null | |||
|
|||
function connect () { | |||
var options = parse(url) | |||
var options = url | |||
if (typeof url === 'string') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes sense; the spec does say that a URL record is acceptable. Would you mind added a test for this?
With this change we can use
eventsource
even when calling a server over a unix domain socket, for example: