Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to only comment on changes, failures, ... #248

Merged
merged 26 commits into from Jun 20, 2022
Merged

Allow to only comment on changes, failures, ... #248

merged 26 commits into from Jun 20, 2022

Conversation

EnricoMi
Copy link
Owner

Fixes #41.

@github-actions
Copy link

github-actions bot commented Apr 15, 2022 •
edited

Unit Test Results (Linux)

     18 files   -      36       18 suites   - 36   1m 25s ⏱️ - 1m 27s
   280 tests +     13     270 ✔️ +       3      0 💤 ±    0    10 ❌ +  10 
5 040 runs   - 9 378  4 740 ✔️  - 9 246  144 💤  - 288  156 ❌ +156 

For more details on these failures, see this check.

Results for commit bf6f62a. ± Comparison against base commit 0ee9ecd.

♻️ This comment has been updated with latest results.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link

github-actions bot commented Apr 15, 2022 •
edited

Unit Test Results (macOS)

     18 files   -      36       18 suites   - 36   1m 25s ⏱️ - 1m 27s
   280 tests +     13     270 ✔️ +       3      0 💤 ±    0    10 ❌ +  10 
5 040 runs   - 9 378  4 740 ✔️  - 9 246  144 💤  - 288  156 ❌ +156 

For more details on these failures, see this check.

Results for commit bf6f62a. ± Comparison against base commit 0ee9ecd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 15, 2022 •
edited

Unit Test Results (Test Files)

  25 files  ±0      4 errors  22 suites  ±0   39m 12s ⏱️ ±0s
272 tests ±0  227 ✔️ ±0  18 💤 ±0  23 ❌ ±0  4 🔥 ±0 
443 runs  ±0  357 ✔️ ±0  55 💤 ±0  26 ❌ ±0  5 🔥 ±0 

For more details on these parsing errors, failures and errors, see this check.

Results for commit bf6f62a. ± Comparison against base commit 0ee9ecd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 15, 2022 •
edited

Unit Test Results (Dockerfile)

     18 files   -      36       18 suites   - 36   1m 25s ⏱️ - 1m 27s
   280 tests +     13     270 ✔️ +       3      0 💤 ±    0    10 ❌ +  10 
5 040 runs   - 9 378  4 740 ✔️  - 9 246  144 💤  - 288  156 ❌ +156 

For more details on these failures, see this check.

Results for commit bf6f62a. ± Comparison against base commit 0ee9ecd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 15, 2022 •
edited

Unit Test Results (Windows)

     18 files   -      36       18 suites   - 36   1m 25s ⏱️ - 1m 27s
   280 tests +     13     270 ✔️ +       3      0 💤 ±    0    10 ❌ +  10 
5 040 runs   - 9 378  4 740 ✔️  - 9 246  144 💤  - 288  156 ❌ +156 

For more details on these failures, see this check.

Results for commit bf6f62a. ± Comparison against base commit 0ee9ecd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 15, 2022 •
edited

Unit Test Results (Docker Image)

     18 files   -      36       18 suites   - 36   1m 25s ⏱️ - 1m 27s
   280 tests +     13     270 ✔️ +       3      0 💤 ±    0    10 ❌ +  10 
5 040 runs   - 9 378  4 740 ✔️  - 9 246  144 💤  - 288  156 ❌ +156 

For more details on these failures, see this check.

Results for commit bf6f62a. ± Comparison against base commit 0ee9ecd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 15, 2022 •
edited

Unit Test Results (reference)

     18 files   -      36       18 suites   - 36   1m 25s ⏱️ - 1m 27s
   280 tests +     13     270 ✔️ +       3      0 💤 ±    0    10 ❌ +  10 
5 040 runs   - 9 378  4 740 ✔️  - 9 246  144 💤  - 288  156 ❌ +156 

For more details on these failures, see this check.

Results for commit bf6f62a. ± Comparison against base commit 0ee9ecd.

♻️ This comment has been updated with latest results.

@EnricoMi EnricoMi marked this pull request as ready for review April 15, 2022 20:06
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link

Unit Test Results (setup-python)

     18 files   -      36       18 suites   - 36   1m 25s ⏱️ - 1m 27s
   280 tests +     13     270 ✔️ +       3      0 💤 ±    0    10 ❌ +  10 
5 040 runs   - 9 378  4 740 ✔️  - 9 246  144 💤  - 288  156 ❌ +156 

For more details on these failures, see this check.

Results for commit bf6f62a. ± Comparison against base commit 0ee9ecd.

@EnricoMi EnricoMi force-pushed the master branch 7 times, most recently from 3a1f2bd to b8402a4 Compare May 23, 2022 18:16
@EnricoMi
Reworking changes and failure logic
0f328a2 
- Move require_comment from Settings into Publisher
- Move has_changes into UnitTestRunDeltaResults
- Add has_changes to SomeTestChanges
- Update tests
@EnricoMi
Fix imports in test_publisher and test_publish
4640423
@EnricoMi
Fix some typos and debug settings
f80f963
@EnricoMi
Use latest action comment on PR for require_comment
5d73a16
@EnricoMi
Make require_comment use stats from earlier comment digest
83540e1
@EnricoMi
Remove unrelevant call assertions
3efede1
@EnricoMi
Rephrase comment_on description
9e4dba9
@EnricoMi
Replace PR by pull request in README.md and action.yml
c1d7b74
@EnricoMi
Return int and not Optional[int]
f0ff707
@EnricoMi
Turn comment_on into set, make failure and error distjoint
fb75107
@EnricoMi
Exclude commit from stats comparison, improve info log
9632dcf
@EnricoMi
Compare ParseErrors as dicts
2a10883
@EnricoMi
Ignore errors as they are not stored in the digest
b424ac7
@EnricoMi
Explain why comment is required
122ba46
@EnricoMi
Rename patched ne function
49aad59
@EnricoMi
Minor changes to debug logging
6fb32c7
@EnricoMi
Add newline after digest, detect end of digest
b64a311
@EnricoMi
Remove SomeTestChanges from detecting changes
1cb1378
@EnricoMi
Improving info logging
b5f2e37
@EnricoMi
Remove comment_on set, integrate into comment_mode, deprecate create …
8b5c71b 
…and update
@EnricoMi
Add comment mode failure and error changes
d025fe4
@EnricoMi
Reduce complexity of require_comment
44b1ee0
@github-actions
Copy link

Test Results (setup-python)

       69 files  ±       0         69 suites  ±0   16m 52s ⏱️ + 13m 12s
     308 tests +     18       308 ✔️ +     18      0 💤 ±0  0 ❌ ±0 
21 252 runs  +1 242  20 712 ✔️ +1 242  540 💤 ±0  0 ❌ ±0 

Results for commit 44b1ee0. ± Comparison against base commit ca6e0bd.

This pull request removes 3 and adds 21 tests. Note that renamed tests count towards both. 
test_publisher.TestPublisher ‑ test_reuse_comment_multiple_existing
test_publisher.TestPublisher ‑ test_reuse_comment_non_existing
test_publisher.TestPublisher ‑ test_reuse_comment_one_existing

test_publish.PublishTest ‑ test_test_changes_has_changes
test_publisher.TestPublisher ‑ test_get_stats_from_summary_md
test_publisher.TestPublisher ‑ test_get_stats_from_summary_md_recycled
test_publisher.TestPublisher ‑ test_publish_comment_not_required
test_publisher.TestPublisher ‑ test_require_comment_always
test_publisher.TestPublisher ‑ test_require_comment_changes
test_publisher.TestPublisher ‑ test_require_comment_changes_errors
test_publisher.TestPublisher ‑ test_require_comment_changes_failures
test_publisher.TestPublisher ‑ test_require_comment_create
test_publisher.TestPublisher ‑ test_require_comment_errors
…

@github-actions
Copy link

github-actions bot commented Jun 14, 2022 •
edited

Test Results (Docker Image)

       69 files  ±       0         69 suites  ±0   15m 55s ⏱️ + 12m 23s
     308 tests +     18       308 ✔️ +     18      0 💤 ±0  0 ❌ ±0 
21 252 runs  +1 242  20 712 ✔️ +1 242  540 💤 ±0  0 ❌ ±0 

Results for commit f94f45c. ± Comparison against base commit ca6e0bd.

This pull request removes 3 and adds 21 tests. Note that renamed tests count towards both. 
test_publisher.TestPublisher ‑ test_reuse_comment_multiple_existing
test_publisher.TestPublisher ‑ test_reuse_comment_non_existing
test_publisher.TestPublisher ‑ test_reuse_comment_one_existing

test_publish.PublishTest ‑ test_test_changes_has_changes
test_publisher.TestPublisher ‑ test_get_stats_from_summary_md
test_publisher.TestPublisher ‑ test_get_stats_from_summary_md_recycled
test_publisher.TestPublisher ‑ test_publish_comment_not_required
test_publisher.TestPublisher ‑ test_require_comment_always
test_publisher.TestPublisher ‑ test_require_comment_changes
test_publisher.TestPublisher ‑ test_require_comment_changes_errors
test_publisher.TestPublisher ‑ test_require_comment_changes_failures
test_publisher.TestPublisher ‑ test_require_comment_create
test_publisher.TestPublisher ‑ test_require_comment_errors
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Test Results (setup-python)

       69 files  ±       0         69 suites  ±0   15m 55s ⏱️ + 12m 23s
     308 tests +     18       308 ✔️ +     18      0 💤 ±0  0 ❌ ±0 
21 252 runs  +1 242  20 712 ✔️ +1 242  540 💤 ±0  0 ❌ ±0 

Results for commit f94f45c. ± Comparison against base commit ca6e0bd.

This pull request removes 3 and adds 21 tests. Note that renamed tests count towards both. 
test_publisher.TestPublisher ‑ test_reuse_comment_multiple_existing
test_publisher.TestPublisher ‑ test_reuse_comment_non_existing
test_publisher.TestPublisher ‑ test_reuse_comment_one_existing

test_publish.PublishTest ‑ test_test_changes_has_changes
test_publisher.TestPublisher ‑ test_get_stats_from_summary_md
test_publisher.TestPublisher ‑ test_get_stats_from_summary_md_recycled
test_publisher.TestPublisher ‑ test_publish_comment_not_required
test_publisher.TestPublisher ‑ test_require_comment_always
test_publisher.TestPublisher ‑ test_require_comment_changes
test_publisher.TestPublisher ‑ test_require_comment_changes_errors
test_publisher.TestPublisher ‑ test_require_comment_changes_failures
test_publisher.TestPublisher ‑ test_require_comment_create
test_publisher.TestPublisher ‑ test_require_comment_errors
…

@EnricoMi EnricoMi merged commit 1806ee6 into devel-1.0 Jun 20, 2022
@EnricoMi EnricoMi deleted the branch-comment-condition branch June 20, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make action only comment on Pull Request if there are failures, errors or more skips
1 participant
@EnricoMi