Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to only comment on changes, failures, ... #248

Merged
merged 26 commits into from Jun 20, 2022
Merged

Allow to only comment on changes, failures, ... #248

merged 26 commits into from Jun 20, 2022

Commits on Jun 14, 2022

  1. Allow to only comment on changes, failures, ...

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    a46a5f5 View commit details
    Browse the repository at this point in the history

  2. Add new option as 'comment_on' to action.yml

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    f1125fc View commit details
    Browse the repository at this point in the history

  3. Reworking changes and failure logic 

    - Move require_comment from Settings into Publisher
- Move has_changes into UnitTestRunDeltaResults
- Add has_changes to SomeTestChanges
- Update tests
    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    0f328a2 View commit details
    Browse the repository at this point in the history

  4. Fix imports in test_publisher and test_publish

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    4640423 View commit details
    Browse the repository at this point in the history

  5. Fix some typos and debug settings

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    f80f963 View commit details
    Browse the repository at this point in the history

  6. Use latest action comment on PR for require_comment

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    5d73a16 View commit details
    Browse the repository at this point in the history

  7. Make require_comment use stats from earlier comment digest

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    83540e1 View commit details
    Browse the repository at this point in the history

  8. Remove unrelevant call assertions

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    3efede1 View commit details
    Browse the repository at this point in the history

  9. Rephrase comment_on description

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    9e4dba9 View commit details
    Browse the repository at this point in the history

  10. Replace PR by pull request in README.md and action.yml

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    c1d7b74 View commit details
    Browse the repository at this point in the history

  11. Return int and not Optional[int]

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    f0ff707 View commit details
    Browse the repository at this point in the history

  12. Turn comment_on into set, make failure and error distjoint

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    fb75107 View commit details
    Browse the repository at this point in the history

  13. Exclude commit from stats comparison, improve info log

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    9632dcf View commit details
    Browse the repository at this point in the history

  14. Compare ParseErrors as dicts

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    2a10883 View commit details
    Browse the repository at this point in the history

  15. Ignore errors as they are not stored in the digest

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    b424ac7 View commit details
    Browse the repository at this point in the history

  16. Explain why comment is required

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    122ba46 View commit details
    Browse the repository at this point in the history

  17. Rename patched ne function

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    49aad59 View commit details
    Browse the repository at this point in the history

  18. Minor changes to debug logging

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    6fb32c7 View commit details
    Browse the repository at this point in the history

  19. Add newline after digest, detect end of digest

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    b64a311 View commit details
    Browse the repository at this point in the history

  20. Remove SomeTestChanges from detecting changes

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    1cb1378 View commit details
    Browse the repository at this point in the history

  21. Improving info logging

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    b5f2e37 View commit details
    Browse the repository at this point in the history

  22. Remove comment_on set, integrate into comment_mode, deprecate create … 

    …and update
    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    8b5c71b View commit details
    Browse the repository at this point in the history

  23. Add comment mode failure and error changes

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    d025fe4 View commit details
    Browse the repository at this point in the history

  24. Reduce complexity of require_comment

    @EnricoMi
    EnricoMi committed Jun 14, 2022
    Copy the full SHA
    44b1ee0 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Remove comment_on from action.yml and README.md

    @EnricoMi
    EnricoMi committed Jun 15, 2022
    Copy the full SHA
    f3ad965 View commit details
    Browse the repository at this point in the history

  2. Adjust tests for new comment modes

    @EnricoMi
    EnricoMi committed Jun 15, 2022
    Copy the full SHA
    f94f45c View commit details
    Browse the repository at this point in the history