Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require symfony/flex globally #5330

Merged

Conversation

javiereguiluz
Copy link
Collaborator

All this work was done by @alexislefebvre. He cannot submit a PR directly because of the temporary restrictions of this repository, so I'm creating the PR on his behalf. Thanks!

@javiereguiluz javiereguiluz added this to the 4.x milestone Jul 11, 2022
@javiereguiluz javiereguiluz merged commit 66c16a0 into EasyCorp:4.x Jul 11, 2022
@alexislefebvre alexislefebvre deleted the don-t-require-symfony/flex-globally branch July 11, 2022 20:58
@alexislefebvre
Copy link
Contributor

Note for future readers: Seldaek recommended to not install flex globally:

I'm well aware of that part but I don't understand the point of having it globally installed then. For those use cases, the project itself should really require symfony/flex in composer.json to ensure it's always present.

Source: shivammathur/setup-php#611 (comment)

javiereguiluz added a commit that referenced this pull request Aug 5, 2022
This PR was merged into the 4.x branch.

Discussion
----------

add symfony/flex to require-dev

Follow-up of #5330

There's no need to require `symfony/flex` on the CI, it can be added to `required-dev`.

This is the same idea than symfony/symfony-docs#17031

Commits
-------

e07ff0b add symfony/flex to require-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants