Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for OSRM server routing only by foot profile #6

Merged
merged 11 commits into from Dec 21, 2020
Merged

fix for OSRM server routing only by foot profile #6

merged 11 commits into from Dec 21, 2020

Conversation

bitsandbricks
Copy link
Contributor

See issue #5

@Claudio9701 Claudio9701 self-requested a review December 21, 2020 03:46
Claudio9701
Claudio9701 approved these changes Dec 21, 2020
View reviewed changes
Copy link
Collaborator

@Claudio9701 Claudio9701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🚀 Please take a look a the question about the tqdm import. After that, I can merge the PR.

notebooks/Demo.ipynb Outdated Show resolved Hide resolved
@Claudio9701 Claudio9701 added the bug Something isn't working label Dec 21, 2020
@Claudio9701 Claudio9701 linked an issue Dec 21, 2020 that may be closed by this pull request
OSRM server always routes using the "foot" profile #5
Closed
@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Claudio9701 Claudio9701 merged commit b0faee8 into EL-BID:master Dec 21, 2020
Claudio9701
Claudio9701 reviewed Dec 21, 2020
View reviewed changes
Copy link
Collaborator

@Claudio9701 Claudio9701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems ok now. Thanks @bitsandbricks 🤖 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Claudio9701 Claudio9701 Claudio9701 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSRM server always routes using the "foot" profile
2 participants
@bitsandbricks @Claudio9701