Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSRM server always routes using the "foot" profile #5

Closed
bitsandbricks opened this issue Dec 12, 2020 · 1 comment · Fixed by #6
Closed

OSRM server always routes using the "foot" profile #5

bitsandbricks opened this issue Dec 12, 2020 · 1 comment · Fixed by #6
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@bitsandbricks
Copy link
Contributor

Because the foot profile is harcoded in line 78, routing/routing.py:

docker run -t --name osrm_extract -v $(pwd):/data osrm/osrm-backend osrm-extract -p **/opt/foot.lua** /data/{country}-latest.osm.pbf;

maybe

start_osrm_server(country, continent)

can be modified as start_osrm_server(country, continent, **profile**) to accept one of {'foot', 'car', 'bicycle'} as does osrm_route(origin, destination, profile)

and then run the docker line pasting in the chosen profile

@bitsandbricks bitsandbricks changed the title OSRM server always route using the "foot" profile OSRM server always routes using the "foot" profile Dec 12, 2020
@Claudio9701 Claudio9701 added bug Something isn't working good first issue Good for newcomers labels Dec 12, 2020
@Claudio9701 Claudio9701 self-assigned this Dec 12, 2020
@Claudio9701
Copy link
Collaborator

Hi @bitsandbricks, Thanks for the issue, you're totally right. I will definitely work on this next week, feel free to collaborate (with a pr) if you want.

bitsandbricks added a commit to bitsandbricks/urbanpy that referenced this issue Dec 13, 2020
@Claudio9701 Claudio9701 linked a pull request Dec 21, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants