Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest pre-commit #195

Merged
merged 1 commit into from Nov 1, 2022
Merged

Conversation

joro75
Copy link
Collaborator

@joro75 joro75 commented Nov 1, 2022

Update to latest pre-commit to resolve problems with dependabot Pull Requests.

This is caused by the problem as described on: pre-commit/pre-commit#2122

Update to latest pre-commit to resolve problems with dependabot Pull Requests
Copy link
Owner

@DurgNomis-drol DurgNomis-drol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

But why does the tests fail in this PR or is this a fix for that?

@DurgNomis-drol DurgNomis-drol merged commit 38063e4 into master Nov 1, 2022
@joro75 joro75 deleted the FixDependabotPullRequests branch November 1, 2022 21:10
@joro75
Copy link
Collaborator Author

joro75 commented Nov 1, 2022

@DurgNomis-drol
I suspect that the failing tests are caused because it is today the first of the month. And that is giving problems in retrieving the statistical information. Is also do remember that this can happen on Sundays (being the first day of the week). And it is related to the issue #144.

It is still on my list to be fixed in the future.

I also do expect that the tests will be passing again tomorrow. (I will check)

@DurgNomis-drol
Copy link
Owner

I forgot about that 😃

Someday I hope that Toyota will fix their nightmare of an API, but hell will probably freeze over first, or maybe we will get two Sundays in the same week 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants