Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update poetry.lock file to update dependency versions to resolve Dependabot PR's #196

Merged
merged 5 commits into from Nov 3, 2022

Conversation

joro75
Copy link
Collaborator

@joro75 joro75 commented Nov 1, 2022

Update poetry.lock file to update dependency versions.

This is related to the PR #195. That PR didn't fix the problems with the Dependabot updates. Still a poetry update was needed to update the 'poetry.lock' file.
The 'nodeenv' version is now updated to 1.7.0, which should resolve the problem of the other dependabot pull requests.

@joro75 joro75 marked this pull request as draft November 1, 2022 21:44
@joro75
Copy link
Collaborator Author

joro75 commented Nov 1, 2022

😡😡 Grmbl... Still not working as expected at this moment....
Do not approve, until I have investigated and resolved why this is still a problem.

@joro75
Copy link
Collaborator Author

joro75 commented Nov 3, 2022

The problem seems to be caused by an older version of Poetry that was used by the Github workflows.
This has now been updated, and also some other packagers are updated to a more up to date version, to resolve some problems.

@joro75 joro75 marked this pull request as ready for review November 3, 2022 20:36
@joro75
Copy link
Collaborator Author

joro75 commented Nov 3, 2022

After this PR is merged in the 'master' branch, I expect that also the other outstanding 'dependabot' PR's can be merged again.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #196 (cc9877a) into master (374a0a5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files          28       28           
  Lines        1463     1463           
=======================================
  Hits         1380     1380           
  Misses         83       83           
Flag Coverage Δ
unittests 94.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DurgNomis-drol DurgNomis-drol merged commit c599bde into DurgNomis-drol:master Nov 3, 2022
@joro75 joro75 deleted the UpdatePoetryLock branch November 3, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants