Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-simple-maps] Add explicit types for children #67195

Conversation

lukask-proxora
Copy link
Contributor

@lukask-proxora lukask-proxora commented Oct 26, 2023

Some components that do implement children relied on their implicit declaration from React.FunctionComponent or React.Component. However, this implicit declaration was removed in @types/react (#56210).

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 26, 2023

@lukask-proxora Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 67195,
  "author": "lukask-proxora",
  "headCommitOid": "e4bcb5a802b12d68b444a123e5647a166ecd238b",
  "mergeBaseOid": "69dbf71884516a8707ed260e96725a9efb8c92b0",
  "lastPushDate": "2023-10-26T07:36:42.000Z",
  "lastActivityDate": "2023-11-21T06:55:24.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2023-11-21T04:20:23.000Z",
  "mergeRequestDate": "2023-11-21T06:55:24.000Z",
  "mergeRequestUser": "lukask-proxora",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "react-simple-maps",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-simple-maps/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "thepocp",
        "pronebird",
        "komenank"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gabritto",
      "date": "2023-11-21T04:19:39.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1780573876,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Oct 26, 2023
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Oct 26, 2023
@typescript-bot
Copy link
Contributor

Hey @lukask-proxora,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @thepocp @pronebird @komenank — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

react-simple-maps (unpkg)

was missing the following properties:

  1. MapContext
  2. MapProvider
  3. ZoomPanContext
  4. ZoomPanProvider
  5. useGeographies
as well as these 3 other properties...

useMapContext, useZoomPan, useZoomPanContext

Generated by 🚫 dangerJS against e4bcb5a

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Oct 26, 2023
@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Oct 30, 2023
@typescript-bot
Copy link
Contributor

Re-ping @thepocp, @pronebird, @komenank:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Nov 6, 2023
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @lukask-proxora.

(Ping @thepocp, @pronebird, @komenank.)

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Nov 21, 2023
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Nov 21, 2023
@typescript-bot
Copy link
Contributor

@lukask-proxora: Everything looks good here. I am ready to merge this PR (at e4bcb5a) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@thepocp, @pronebird, @komenank: you can do this too.)

@lukask-proxora
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Nov 21, 2023
@typescript-bot typescript-bot merged commit de752ad into DefinitelyTyped:master Nov 21, 2023
2 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants