New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-simple-maps] Add explicit types for children #67195
[react-simple-maps] Add explicit types for children #67195
Conversation
@lukask-proxora Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 67195,
"author": "lukask-proxora",
"headCommitOid": "e4bcb5a802b12d68b444a123e5647a166ecd238b",
"mergeBaseOid": "69dbf71884516a8707ed260e96725a9efb8c92b0",
"lastPushDate": "2023-10-26T07:36:42.000Z",
"lastActivityDate": "2023-11-21T06:55:24.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"mergeOfferDate": "2023-11-21T04:20:23.000Z",
"mergeRequestDate": "2023-11-21T06:55:24.000Z",
"mergeRequestUser": "lukask-proxora",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-simple-maps",
"kind": "edit",
"files": [
{
"path": "types/react-simple-maps/index.d.ts",
"kind": "definition"
}
],
"owners": [
"thepocp",
"pronebird",
"komenank"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gabritto",
"date": "2023-11-21T04:19:39.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1780573876,
"ciResult": "pass"
} |
Hey @lukask-proxora, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
🔔 @thepocp @pronebird @komenank — please review this PR in the next few days. Be sure to explicitly select |
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. react-simple-maps (unpkg)was missing the following properties:
as well as these 3 other properties...useMapContext, useZoomPan, useZoomPanContext |
Re-ping @thepocp, @pronebird, @komenank: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @lukask-proxora. (Ping @thepocp, @pronebird, @komenank.) |
@lukask-proxora: Everything looks good here. I am ready to merge this PR (at e4bcb5a) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@thepocp, @pronebird, @komenank: you can do this too.) |
Ready to merge |
Some components that do implement children relied on their implicit declaration from React.FunctionComponent or React.Component. However, this implicit declaration was removed in
@types/react
(#56210).Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If changing an existing definition: