New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types are not compatible with the React 18 types #347

Closed

lukask-proxora opened this issue Nov 15, 2023 · 1 comment

lukask-proxora commented Nov 15, 2023

In this PR in DefinitelyTyped for the React 18 type, the implicit children prop for React components was removed.

This leads to an incompatibility of the react-simple-maps types with the React 18 types.

I created a PR to fix this: DefinitelyTyped/DefinitelyTyped#67195

However, the maintainers of the react-simple-maps module in the DefinitelyTyped repository do not seem to react to my PR.

Author

lukask-proxora commented Nov 21, 2023

Closing this issue, since the PR got approved.

Thanks for helping! 👍

lukask-proxora closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment