Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove multiple workbox-_ DT packages, resolve versions mismatch #63682

Merged
merged 25 commits into from Jan 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
2e9855e
chore[next-pwa]: resolve `workbox-build` types package versions mismatch
NivaldoFarias Dec 20, 2022
3b8dacc
chore[next-pwa]: add tests to check type `WebpackConfigOptions`
NivaldoFarias Dec 20, 2022
bb95d49
chore[next-pwa]: remove `@types/workbox-build` in favour of package t…
NivaldoFarias Dec 20, 2022
f784711
fix[next-pwa]: bump minimum Typescript version from `4.6` to `4.9`
NivaldoFarias Dec 20, 2022
005a847
Merge branch 'DefinitelyTyped:master' into master
NivaldoFarias Dec 22, 2022
c1b3c46
chore[next-pwa]: revert minimin ts version to `4.5`
NivaldoFarias Dec 22, 2022
3592d93
Merge branch 'DefinitelyTyped:master' into master
NivaldoFarias Dec 22, 2022
eb0d61a
fix[next-pwa]: remove stale `workbox-_` DT packages
NivaldoFarias Dec 22, 2022
9bcdc74
deps: remove multiple `workbox-_` DT packages
NivaldoFarias Dec 22, 2022
1960380
deps: remove even MORE `workbox-_` DT packages
NivaldoFarias Dec 22, 2022
def05cf
Revert "fix[next-pwa]: remove stale `workbox-_` DT packages"
NivaldoFarias Dec 22, 2022
c42cf7b
Revert "deps: remove multiple `workbox-_` DT packages"
NivaldoFarias Dec 22, 2022
bedee5e
Revert "deps: remove even MORE `workbox-_` DT packages"
NivaldoFarias Dec 22, 2022
546d5cc
revert: remove `workbox-sw` from not-needed packages file
NivaldoFarias Dec 22, 2022
d4a36c4
Merge branch 'DefinitelyTyped:master' into master
NivaldoFarias Dec 22, 2022
6051810
fix[customize-cra]: add module interop flag; add lib
NivaldoFarias Dec 22, 2022
1d775ba
deps[workbox-sw]: add workbox packages to `packages.json`
NivaldoFarias Dec 22, 2022
113bfca
chore[workbox-sw]: add tests
NivaldoFarias Dec 22, 2022
291e7d9
chore: use `@types/` deps to refer to old DT packages types
NivaldoFarias Dec 26, 2022
d7508f4
chore: remove `esModuleInterop` flag
NivaldoFarias Dec 26, 2022
128c17b
chore[customize-cra]: remove `webworker` lib
NivaldoFarias Dec 26, 2022
779e049
Merge branch 'DefinitelyTyped:master' into master
NivaldoFarias Dec 28, 2022
6b06f6d
Merge branch 'DefinitelyTyped:master' into master
NivaldoFarias Dec 30, 2022
0ce958a
Merge branch 'DefinitelyTyped:master' into master
NivaldoFarias Jan 2, 2023
2ffa505
fix: correct import statements
NivaldoFarias Jan 2, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
60 changes: 60 additions & 0 deletions notNeededPackages.json
Expand Up @@ -5975,6 +5975,66 @@
"libraryName": "words-to-numbers",
"asOfVersion": "1.3.0"
},
"workbox-background-sync": {
"libraryName": "workbox-background-sync",
"asOfVersion": "5.0.0"
},
"workbox-broadcast-update": {
"libraryName": "workbox-broadcast-update",
"asOfVersion": "5.0.0"
},
"workbox-build": {
"libraryName": "workbox-build",
"asOfVersion": "5.1.0"
},
"workbox-cacheable-response": {
"libraryName": "workbox-cacheable-response",
"asOfVersion": "5.0.0"
},
"workbox-core": {
"libraryName": "workbox-core",
"asOfVersion": "5.0.0"
},
"workbox-expiration": {
"libraryName": "workbox-expiration",
"asOfVersion": "5.0.0"
},
"workbox-google-analytics": {
"libraryName": "workbox-google-analytics",
"asOfVersion": "5.0.0"
},
"workbox-navigation-preload": {
"libraryName": "workbox-navigation-preload",
"asOfVersion": "5.0.0"
},
"workbox-precaching": {
"libraryName": "workbox-precaching",
"asOfVersion": "5.0.0"
},
"workbox-range-requests": {
"libraryName": "workbox-range-requests",
"asOfVersion": "5.0.0"
},
"workbox-routing": {
"libraryName": "workbox-routing",
"asOfVersion": "5.0.0"
},
"workbox-strategies": {
"libraryName": "workbox-strategies",
"asOfVersion": "5.0.0"
},
"workbox-streams": {
"libraryName": "workbox-streams",
"asOfVersion": "5.0.0"
},
"workbox-webpack-plugin": {
"libraryName": "workbox-webpack-plugin",
"asOfVersion": "6.0.0"
},
"workbox-window": {
"libraryName": "workbox-window",
"asOfVersion": "5.0.0"
},
"wouter": {
"libraryName": "wouter",
"asOfVersion": "2.2.0"
Expand Down
6 changes: 5 additions & 1 deletion types/customize-cra/customize-cra-tests.ts
Expand Up @@ -36,7 +36,11 @@ module.exports = override(
['ag-grid-react$']: path.resolve(__dirname, 'src/shared/agGridWrapper.js'),
}),

adjustWorkbox(wb => ({ ...wb, skipWaiting: true, exclude: (wb.exclude || []).concat('index.html') })),
adjustWorkbox(workbox => ({
...workbox,
skipWaiting: true,
exclude: (workbox.exclude || []).concat('index.html'),
})),
);

module.exports = {
Expand Down
6 changes: 6 additions & 0 deletions types/customize-cra/package.json
@@ -0,0 +1,6 @@
{
"private": true,
"dependencies": {
"@types/workbox-webpack-plugin": "^5.1.8"
}
}
10 changes: 2 additions & 8 deletions types/next-pwa/index.d.ts
Expand Up @@ -2,19 +2,13 @@
// Project: https://github.com/shadowwalker/next-pwa#readme
// Definitions by: Nivaldo Farias <https://github.com/NivaldoFarias>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// Minimum TypeScript Version: 4.6
// Minimum TypeScript Version: 4.5

/// <reference types="react"/>

import type { RuntimeCaching, GenerateSWOptions, InjectManifestOptions } from 'workbox-build';
import type { NextConfig } from 'next';

// match `workbox-build` ^6.5.4 types naming
import type {
RuntimeCachingEntry as RuntimeCaching,
GenerateSWConfig as GenerateSWOptions,
InjectManifestConfig as InjectManifestOptions,
} from 'workbox-build';

declare global {
interface PopStateEventInit extends EventInit {
state?: unknown;
Expand Down
9 changes: 7 additions & 2 deletions types/next-pwa/next-pwa-tests.ts
Expand Up @@ -6,11 +6,16 @@ const withPWA = nextPWA({
dest: 'public',
});

// $ExpectType NextConfig & PWAConfig
const outputConfig = withPWA({});

const errorWithPWA = nextPWA({
dest: 'public',
// @ts-expect-error
register: 'error',
});

// $ExpectType NextConfig & PWAConfig
const outputConfig = withPWA({});
const webpackConfigOptions: nextPWA.WebpackConfigOptions = {
// @ts-expect-error
swDest: true,
};
3 changes: 2 additions & 1 deletion types/next-pwa/package.json
@@ -1,6 +1,7 @@
{
"private": true,
"dependencies": {
"next": "^12.2.5"
"next": "^12.2.5",
"workbox-build": "^6.5.4"
}
}
11 changes: 0 additions & 11 deletions types/workbox-background-sync/Plugin.d.ts

This file was deleted.

29 changes: 0 additions & 29 deletions types/workbox-background-sync/Queue.d.ts

This file was deleted.

8 changes: 0 additions & 8 deletions types/workbox-background-sync/index.d.ts

This file was deleted.

24 changes: 0 additions & 24 deletions types/workbox-background-sync/tsconfig.json

This file was deleted.

1 change: 0 additions & 1 deletion types/workbox-background-sync/tslint.json

This file was deleted.

62 changes: 0 additions & 62 deletions types/workbox-background-sync/workbox-background-sync-tests.ts

This file was deleted.

20 changes: 0 additions & 20 deletions types/workbox-broadcast-update/BroadcastCacheUpdate.d.ts

This file was deleted.

11 changes: 0 additions & 11 deletions types/workbox-broadcast-update/Plugin.d.ts

This file was deleted.

7 changes: 0 additions & 7 deletions types/workbox-broadcast-update/broadcastUpdate.d.ts

This file was deleted.

9 changes: 0 additions & 9 deletions types/workbox-broadcast-update/index.d.ts

This file was deleted.

24 changes: 0 additions & 24 deletions types/workbox-broadcast-update/tsconfig.json

This file was deleted.

1 change: 0 additions & 1 deletion types/workbox-broadcast-update/tslint.json

This file was deleted.