New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resimplify types versions #63425
Resimplify types versions #63425
Conversation
Matches microsoft/DefinitelyTyped-tools#572 The current, less-obvious format works around a bug in Typescript 4.9 and earlier. That's fixed in 4.9, and was in any case only relevant when node types needed to refer to 4.9 before it had shipped.
@sandersn Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 5 packages in this PR (and infra files)
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 63425,
"author": "sandersn",
"headCommitOid": "16d201cf985ad9544035d0294f5116de9f0c12ae",
"mergeBaseOid": "65b97fc510ab85a1177852096b8a8be753056290",
"lastPushDate": "2022-11-30T18:03:19.000Z",
"lastActivityDate": "2022-11-30T18:25:56.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "docs/support-window.json",
"kind": "infrastructure"
},
{
"path": "docs/support-window.svg",
"kind": "infrastructure"
},
{
"path": "package.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "dom-mediacapture-record",
"kind": "edit",
"files": [
{
"path": "types/dom-mediacapture-record/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"elsmr",
"AppLover69"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "googletag",
"kind": "edit",
"files": [
{
"path": "types/googletag/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"atwwei"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "har-format",
"kind": "edit",
"files": [
{
"path": "types/har-format/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"micmro",
"marcelltoth"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "lodash",
"kind": "edit",
"files": [
{
"path": "types/lodash/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"bczengel",
"chrootsu",
"aj-r",
"e-cloud",
"thorn0",
"jtmthf",
"DomiR",
"WilliamChelman"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v14/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v16/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2022-11-30T18:25:56.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1331486107,
"ciResult": "pass"
} |
People who would have been pingedelsmr AppLover69 atwwei micmro marcelltoth bczengel chrootsu aj-r e-cloud thorn0 jtmthf DomiR WilliamChelman Microsoft DefinitelyTyped jkomyno alvis r3nya btoueg smac89 touffy DeividasBakanas eyqs Hannes-Magnusson-CK hoo29 kjin ajafff islishude mwiktorczyk mohsen1 n-e galkin parambirs eps1lon SimonSchick ThomasdenH WilcoBakker wwwy3y3 samuela kuehlein bhongy chyzwar trivikr yoursunny qwelias ExE-Boss peterblazejewicz addaleax victorperin ZYSzys NodeJS LinusU wafuwafu13 mcollina |
@sandersn The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Matches microsoft/DefinitelyTyped-tools#572
The current, less-obvious format works around a bug in Typescript 4.9
and earlier. That's fixed in 4.9, and was in any case only relevant when node types
needed to refer to 4.9 before it had shipped.