Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@babel/traverse]: Allowed node aliases as keys in visitors. #32395

Conversation

cameron-martin
Copy link
Contributor

@cameron-martin cameron-martin commented Jan 22, 2019

This is made possible by babel/babel#9110.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

This is made possible by babel/babel#9110.

When the next version after v7.2.2 is released, the package.json can be updated and the build will no longer fail.
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 22, 2019

@cameron-martin Thank you for submitting this PR!

🔔 @yortus @marvinhagemeister @rpetrich @mgroenhoff - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board Jan 27, 2019
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Jan 27, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 27, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot moved this from Review to Check and Merge in Pull Request Status Board Jan 28, 2019
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Jan 28, 2019
@Jessidhia Jessidhia merged commit 6a07032 into DefinitelyTyped:master Jan 28, 2019
@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Jan 28, 2019
@cameron-martin cameron-martin deleted the feature/babel-traverse-node-aliases branch January 28, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants