Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@babel/traverse]: Allowed node aliases as keys in visitors. #31554

Conversation

cameron-martin
Copy link
Contributor

@cameron-martin cameron-martin commented Dec 19, 2018

This is made possible by babel/babel#9110.

When the next version after v7.2.2 is released, the package.json can be updated and the build will no longer fail.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

This is made possible by babel/babel#9110.

When the next version after v7.2.2 is released, the package.json can be updated and the build will no longer fail.
@typescript-bot typescript-bot added this to Needs Author Attention in Pull Request Status Board Dec 19, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 19, 2018

@cameron-martin Thank you for submitting this PR!

🔔 @yortus @marvinhagemeister @rpetrich @mgroenhoff - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 19, 2018

@cameron-martin The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

@cameron-martin I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@cameron-martin
Copy link
Contributor Author

A new version of @babel/types wasn't released when new versions of other packages are released. I've filed this as a bug. babel/babel#9239

@typescript-bot typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Dec 26, 2018
@typescript-bot
Copy link
Contributor

@cameron-martin To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you!

@typescript-bot typescript-bot removed this from Needs Author Attention in Pull Request Status Board Dec 26, 2018
@cameron-martin
Copy link
Contributor Author

Reopened as #32395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned This PR had no activity for a long time, and is considered abandoned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants