Upgrade add-on to Ember.js v5.4.0 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChocolatine
added
dependencies
MrChocolatine
force-pushed
the
upgrade-to-emberjs-5.3.0
branch
from
72dccca
to
92a7823
Compare
This was referenced Oct 29, 2023
|
Ember.js v5.4.0 has just been released, I will apply the change here while I am at it. |
This was referenced Nov 3, 2023
MrChocolatine
changed the title
MrChocolatine
force-pushed
the
upgrade-to-emberjs-5.3.0
branch
from
92a7823
to
03d690d
Compare
MrChocolatine
dismissed
ndekeister-us’s stale review
New review requested: I applied another upgrade (v5.3.0 to v5.4.0)
MrChocolatine
force-pushed
the
upgrade-to-emberjs-5.3.0
branch
4 times, most recently
from
4316c00
to
c2cb36a
Compare
MrChocolatine
force-pushed
the
upgrade-to-emberjs-5.3.0
branch
4 times, most recently
from
10a9303
to
2648586
Compare
|
Calling a last review @ndekeister-us , I dismissed your last approval as I applied another upgrade (v5.3.0 to v5.4.0) after it. |
BREAKING CHANGE: upgrade add-on to Ember.js v5.4.0 - Now require Ember.js v4.8 or above - Now require Ember CLI v4.8 or above - Now require Node.js v18 or above
There were some warnings when running `npm publish --dry-run`: ``` ➜ npm publish --dry-run npm WARN publish npm auto-corrected some errors in your package.json when publishing. Please run "npm pkg fix" to address these errors. npm WARN publish errors corrected: npm WARN publish "repository" was changed from a string to an object npm WARN publish "repository.url" was normalized to "git+https://github.com/DazzlingFugu/ember-feature-controls.git" npm notice ... logs ... ```
Otherwise we get this error when runnning tests: ``` yarn test:ember $ ember test Environment: test cleaning up... Cleanup error. ⠋ cleaning upCannot read properties of undefined (reading 'cleanup') Stack Trace and Error Report: /Applications/code-portable-data/tmp/error.dump.c09e9dbb0ebb48059d2c311cec4335fa.log ember-feature-controls needs to depend on ember-auto-import in order to use ember-truth-helpers Stack Trace and Error Report: /Applications/code-portable-data/tmp/error.dump.dac3bb11d1b83deb32927642f21cb0f4.log error Command failed with exit code 1. ```
Prior to these changes, we were getting this error: ``` Unexpected use of `assert.expect()` call. (eslintqunit/require-expect) ``` from https://github.com/platinumazure/eslint-plugin-qunit/blob/master/docs/rules/require-expect.md
TypeScript error as it is not supposed to be publicly exposed: - emberjs/ember-test-helpers#1306 - https://github.com/emberjs/ember-qunit/blob/v8.0.1/docs/migration.md
1. The coment says this override can be removed once mansona/ember-get-config#29 has been merged, and it was merged. 2. `ember-get-config` package was uninstalled in commit 56b2fe8 .
From https://github.com/kategengler/ember-feature-flags/blob/v6.0.0/README.md?plain=1#L7 > ### Note to users of `ember.js` >= 3.1 > Referencing the features service must be done using `get` as it is a proxy.
MrChocolatine
force-pushed
the
upgrade-to-emberjs-5.3.0
branch
from
2648586
to
aa577c2
Compare
|
PR initially created the 29 October 2023, after 2 weeks I am going to merge it soon. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking
Upgrade add-on to Ember.js v5.4.0 (#255)
Chore
Partially migrate add-on to TypeScript (#255)
The add-on is not 100% TypeScript-based yet, but it was regenerated as if it was, with the latest specification and the
--typescriptflag.--typescriptflag toappandaddonblueprints ember-cli/ember-cli#9972which also means it does not rely on
ember-cli-typescriptanymore:--typescriptsupport in blueprints ember-cli/ember-cli#10283Build
Dependencies updates (#255)
Added
@babel/core@^7.23.2@ember/string@^3.1.1@glint/environment-ember-loose@^1.2.1@glint/template@^1.2.1@typescript-eslint/eslint-plugin@^6.9.1@typescript-eslint/parser@^6.9.1concurrently@^8.2.2ember-cli-clean-css@^3.0.0rimraf@^5.0.1stylelint@^15.11.0stylelint-config-standard@^34.0.0stylelint-prettier@^4.0.2typescript@^5.2.2@ember/string@^3.1.1is now a peer dependencyember-source >= 4.0.0is now a peer dependencyUpdated
ember-auto-import@^2.6.3is now a dependency, not a dev dependencyember-cli-babel@^8.2.0ember-cli-htmlbars@^6.3.0ember-local-storage@^2.0.6ember-truth-helpers@^4.0.3@ember/test-helpers@^3.2.0@embroider/test-setup@^3.0.2@glimmer/component@^1.1.2@glimmer/tracking@^1.1.2ember-auto-import@^2.6.3ember-cli@~5.4.0ember-cli-dependency-checker@^3.3.2ember-page-title@^8.0.0ember-qunit@^8.0.1ember-resolver@^11.0.1ember-source@~5.4.0ember-template-lint@^5.11.2ember-try@^3.0.0eslint@^8.52.0eslint-config-prettier@^9.0.0eslint-plugin-ember@^11.11.1eslint-plugin-n@^16.2.0eslint-plugin-prettier@^5.0.1eslint-plugin-qunit@^8.0.1prettier@^3.0.3qunit@^2.20.0webpack@^5.89.0Removed
@babel/core@^7.18.10@babel/eslint-parser@^7.18.9@babel/plugin-proposal-decorators@^7.18.10ember-disable-prototype-extensions@^1.1.3ember-export-application-global@^2.0.1npm-run-all@^4.1.5Below is just extra text to give more context, but it should not be included in our changelog.
Actions taken
--typescript(using this brings additional changes compared to a simpleember new MyAddon)