Upgrade add-on to Ember.js v5.4.0

[MrChocolatine]

Breaking

Upgrade add-on to Ember.js v5.4.0 (#305)

• Ember.js v4.8 or above is now required
• Ember CLI v4.8 or above is now required
• Node.js v18 or above is now required

Chore

Fully migrate add-on to TypeScript (#305)

• The add-on is now 100% TypeScript-based as it was regenerated with the latest specification and the --typescript flag.

  • https://github.com/ember-cli/ember-cli/releases/tag/v4.9.0
  • [ENHANCEMENT] Add support for --typescript flag to app and addon blueprints ember-cli/ember-cli#9972

  which also means it does not rely on ember-cli-typescript anymore:

  • Refactor --typescript support in blueprints ember-cli/ember-cli#10283

Build

Dependencies updates (#305)

Added

• @babel/core@^7.23.2
• @glint/environment-ember-loose@^1.2.1
• @glint/template@^1.2.1
• broccoli-asset-rev@^3.0.0
• concurrently@^8.2.2
• ember-cli-inject-live-reload@^2.1.0
• ember-cli-sri@^2.1.1
• eslint-config-prettier@^9.0.0
• eslint-plugin-n@^16.2.0
• eslint-plugin-prettier@^5.0.1
• prettier@^3.0.3
• rimraf@^5.0.1
• ember-source >= 4.0.0 is now a peer dependency

Updated

• ember-cli-babel@^8.2.0
• ember-cli-htmlbars@^6.3.0
• @ember/test-helpers@^3.2.0
• @typescript-eslint/eslint-plugin@^6.9.1
• @typescript-eslint/parser@^6.9.1
• ember-auto-import@^2.6.3
• ember-cli@~5.4.0
• ember-cli-dependency-checker@^3.3.2
• ember-qunit@^8.0.1
• ember-source@~5.4.0
• ember-try@^3.0.0
• eslint@^8.52.0
• eslint-plugin-ember@^11.11.1
• eslint-plugin-qunit@^8.0.1
• qunit@^2.20.0
• typescript@^5.2.2
• webpack@^5.89.0

Removed

• ember-cli-typescript@^5.2.1
• babel-eslint@^10.1.0
• ember-cli-typescript-blueprints@^3.0.0
• ember-disable-prototype-extensions@^1.1.3
• ember-template-lint@^5.7.2
• eslint-plugin-node@^11.1.0
• npm-run-all@^4.1.5

---

Supersedes and closes #286 .

---

Below is just extra text to give more context, but it should not be included in our changelog.

Actions taken

1. Fresh add-on created using the latest version of Ember.js + flag --typescript (using this brings additional changes compared to a simple ember new MyAddon)
2. Then re-import everything from our add-on
3. Re-adjust a few things to make it work for our setup

Note to reviewers

When working on this I noticed we had some files that had extra whitespaces:

some content              <= this line has trailing whitespaces
   <= a new line with extra whitespaces too
etc

We are in 2023 we should not encounter such situations anymore, modern tools should take care of this.
Please configure your editor accordingly.

For instance with VSCode you need to enable this setting:

"files.trimTrailingWhitespace": true,

[ndekeister-us]

LGTM 🎉

[ndekeister-us]

Regarding your last commit running manually prettier, maybe in the future we should add some git hooks or something on CI to prevent merging if there are some prettier errors (would have expected them to be detected via the lint job but 🤷‍♂️)

New review requested: I applied another upgrade (v5.3.0 to v5.4.0)

[MrChocolatine]

PR initially created the 28 October 2023, after 2 weeks I am going to merge it soon.