Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/ext: change error.msg to error.message for UNC #1605

Merged
merged 3 commits into from Dec 6, 2022

Conversation

zarirhamza
Copy link
Contributor

What does this PR do?

Renames the error.msg tag to error.message tag in order to meet the requirements of naming across all tracers.

@zarirhamza zarirhamza requested a review from a team December 6, 2022 17:03
@pr-commenter

This comment has been minimized.

@zarirhamza zarirhamza modified the milestones: v1.44.0, v1.45.0 Dec 6, 2022
@knusbaum knusbaum added this to the v1.45.0 milestone Dec 6, 2022
@pr-commenter
Copy link

pr-commenter bot commented Dec 6, 2022

Benchmarks

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@ajgajg1134
Copy link
Contributor

Given this is a publicly available tag is there any concern that customers may be relying on this value for their monitors / metrics?

@zarirhamza
Copy link
Contributor Author

Given this is a publicly available tag is there any concern that customers may be relying on this value for their monitors / metrics?

Nope! This is part of the Unified Naming Changes of which customers have been given ample notice to change their setup and changes to the tracer have been approved by the backend.

@ajgajg1134
Copy link
Contributor

Given this is a publicly available tag is there any concern that customers may be relying on this value for their monitors / metrics?

Nope! This is part of the Unified Naming Changes of which customers have been given ample notice to change their setup and changes to the tracer have been approved by the backend.

OH that's what UNC means :P okay!

@knusbaum knusbaum changed the title Changes error.msg to error.message for UNC ddtrace/ext: change error.msg to error.message for UNC Dec 6, 2022
@knusbaum knusbaum merged commit 58edd67 into main Dec 6, 2022
@knusbaum knusbaum deleted the zarir/error_message branch December 6, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants