Define error metadata tags #2786
Conversation
| @@ -9,6 +9,9 @@ const tags = { | |||
| SAMPLING_PRIORITY: 'sampling.priority', | |||
| ANALYTICS: '_dd1.sr.eausr', | |||
| ERROR: 'error', | |||
| ERROR_MSG: 'error.message', | |||
There was a problem hiding this comment.
📝 dd-trace-go changes error.msg to error.messages on 2022-12-07
DataDog/dd-trace-go#1605
There was a problem hiding this comment.
What is your use case for setting these manually? It should be enough to set the ERROR tag to an error object which will then automatically be converted to the appropriate tags internally. Setting these manually is discouraged.
| @@ -9,6 +9,9 @@ const tags = { | |||
| SAMPLING_PRIORITY: 'sampling.priority', | |||
| ANALYTICS: '_dd1.sr.eausr', | |||
| ERROR: 'error', | |||
| ERROR_MSG: 'error.message', | |||
There was a problem hiding this comment.
What is your use case for setting these manually? It should be enough to set the ERROR tag to an error object which will then automatically be converted to the appropriate tags internally. Setting these manually is discouraged.
|
@izumin5210 it looks like Roch had some open concerns about this PR. Is it something you'd still like to work on? If not I can close it for now. |
|
I'll close this PR for now but we can consider reopening it in the future. |
What does this PR do?
Add error metadata tags to
ext/tags.jsdefined in https://docs.datadoghq.com/tracing/trace_explorer/trace_view/?tab=spantags#more-information