Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/labstack/{echo, echo.v4}: improve error detection #1000

Merged
merged 7 commits into from Dec 9, 2022
Merged

contrib/labstack/{echo, echo.v4}: improve error detection #1000

merged 7 commits into from Dec 9, 2022

Commits on Dec 8, 2022

  1. contrib/labstack/{echo, echo.v4}: improve error detection 

    This adds improved error detection to the echo integrations. Previously,
any returned error was recorded as an error in the echo span. This patch
causes the integration to inspect the returned error to determine if it is
a echo.HTTPError which it can use to discriminate between real errors (5xx
and up) or non-errors (4xx and below)

Fixes #987
    @knusbaum
    knusbaum committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    b21f913 View commit details
    Browse the repository at this point in the history

  2. add/fix unit tests

    @knusbaum
    knusbaum committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    b879761 View commit details
    Browse the repository at this point in the history

  3. add WithStatusCheck option

    @knusbaum
    knusbaum committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    83001e7 View commit details
    Browse the repository at this point in the history

  4. fix and update

    @knusbaum
    knusbaum committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    61a12f3 View commit details
    Browse the repository at this point in the history

  5. cleanup

    @knusbaum
    knusbaum committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    47535f9 View commit details
    Browse the repository at this point in the history

  6. address PR comments

    @knusbaum
    knusbaum committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    be36744 View commit details
    Browse the repository at this point in the history

  7. cleanup

    @knusbaum
    knusbaum committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    649a37b View commit details
    Browse the repository at this point in the history