contrib/labstack/{echo, echo.v4}: improve error detection #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually tested, but need to add unit tests for this. |
|
Done, ready. |
knusbaum
commented
Sep 8, 2021
gbbr
reviewed
Sep 9, 2021
dubonzi
reviewed
Sep 21, 2021
gbbr
reviewed
Sep 29, 2021
|
Moving to 1.35.0. Hope that's ok. Otherwise ping me. |
gbbr
previously approved these changes
Oct 28, 2021
|
LGTM 👍 I'm looking forward to merging. Is there anything I can do ? |
gbbr
reviewed
Jan 17, 2022
This adds improved error detection to the echo integrations. Previously, any returned error was recorded as an error in the echo span. This patch causes the integration to inspect the returned error to determine if it is a echo.HTTPError which it can use to discriminate between real errors (5xx and up) or non-errors (4xx and below) Fixes #987
knusbaum
force-pushed
the
knusbaum/fix-echo
branch
from
8f109ee
to
61a12f3
Compare
ajgajg1134
requested changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds improved error detection to the echo integrations. Previously,
any returned error was recorded as an error in the echo span. This patch
causes the integration to inspect the returned error to determine if it is
a echo.HTTPError which it can use to discriminate between real errors (5xx
and up by default) or non-errors (below 5xx by default)
This also adds a WithStatusCheck Option which allows users to configure
which errors/statuses are reported as errors.
Fixes #987