Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datastreams support for contrib/IBM/sarama.v1 #2481

Open
jieya907 opened this issue Jan 4, 2024 · 2 comments
Open

Add datastreams support for contrib/IBM/sarama.v1 #2481

jieya907 opened this issue Jan 4, 2024 · 2 comments
Assignees
@rarguelloF
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval

Comments

@jieya907
Copy link

jieya907 commented Jan 4, 2024

Sarama used to be owned by Shopify but recently it transitioned to IBM.

There is already an IBM/sarama module. However, it lacks feature parity with the Shopify version. Specifically, it's missing support for the datastream feature.

It would be nice to have the ddsarama.WithDataStreams() option available for IBM/sarama.

Thanks!
@jieya907 jieya907 added the enhancement quick change/addition that does not need full team approval label Jan 4, 2024
@github-actions github-actions bot added the needs-triage New issues that have not yet been triaged label Jan 4, 2024
@felixge felixge added apm:ecosystem contrib/* related feature requests or bugs and removed needs-triage New issues that have not yet been triaged labels Jan 8, 2024
@felixge
Copy link
Member

felixge commented Jan 8, 2024

Thanks for requesting this. Assigning to @DataDog/apm-ecosystems.

@zarirhamza
Copy link
Contributor

zarirhamza commented Feb 20, 2024 •
edited

I think @piochelepiotr implemented this for Shopify/sarama not too long ago. Maybe he can take a look at it again here? It seems to be the same code but I want to confirm that datastreams monitoring will work here

This was referenced Feb 26, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rarguelloF rarguelloF

Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@felixge @rarguelloF @jieya907 @zarirhamza