Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2/contrib/IBM/sarama Feature parity with deprecated shopify/sarama datastreams #2574

Closed

Conversation

KyleWiering
Copy link

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Pulled the changes from DataDog#2006 into the feature branch
@KyleWiering KyleWiering requested review from a team as code owners February 26, 2024 08:21
@KyleWiering KyleWiering marked this pull request as draft February 26, 2024 19:00
@KyleWiering
Copy link
Author

Ah, my merge conflict resolution was not accurate. Converting to draft as it failed the test suites.

@felixge felixge removed the request for review from a team February 27, 2024 07:26
Copy link

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Stuck for more than 1 month label Mar 19, 2024
@KyleWiering KyleWiering deleted the ibm-sarama-datastreams branch March 25, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stuck for more than 1 month
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant