Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2/contrib: Add datastreams support for contrib/IBM/sarama #2573

Open
KyleWiering opened this issue Feb 26, 2024 · 0 comments
Open

v2/contrib: Add datastreams support for contrib/IBM/sarama #2573

KyleWiering opened this issue Feb 26, 2024 · 0 comments
Assignees
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval

Comments

@KyleWiering
Copy link

Referencing #2481

Request Pulling the changes from #2006 into the IBM/sarama module as Shopify no longer supports sarama and the repository has migrated.

It would be nice to have the ddsarama.WithDataStreams() option available for IBM/sarama.

IBM/sarama is using the same code base.

(Disclaimer: I can try creating this PR - first time on looking at this project, I think I've read through all of the contrib docs)

@KyleWiering KyleWiering added the enhancement quick change/addition that does not need full team approval label Feb 26, 2024
@github-actions github-actions bot added apm:ecosystem contrib/* related feature requests or bugs needs-triage New issues that have not yet been triaged labels Feb 26, 2024
KyleWiering added a commit to KyleWiering/dd-trace-go that referenced this issue Feb 26, 2024
Pulled the changes from DataDog#2006 into the feature branch
@darccio darccio removed the needs-triage New issues that have not yet been triaged label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval
Projects
None yet
Development

No branches or pull requests

3 participants