Skip to content

Commit

Permalink
contrib/internal/httptrace: add TODO to track span start options refa…
Browse files Browse the repository at this point in the history
…ctoring
  • Loading branch information
Hellzy committed Jun 22, 2022
1 parent 165f5a5 commit 3eded75
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions contrib/internal/httptrace/httptrace.go
Expand Up @@ -46,6 +46,7 @@ var (
// http.useragent). Any further span start option can be added with opts.
func StartRequestSpan(r *http.Request, opts ...ddtrace.StartSpanOption) (tracer.Span, context.Context) {
// Append our span options before the given ones so that the caller can "overwrite" them.
// TODO(): rework span start option handling (https://github.com/DataDog/dd-trace-go/issues/1352)
opts = append([]ddtrace.StartSpanOption{
tracer.SpanType(ext.SpanTypeWeb),
tracer.Tag(ext.HTTPMethod, r.Method),
Expand Down

0 comments on commit 3eded75

Please sign in to comment.