contrib/internal/httptrace: use strings.Join to build multiple-ip tag

DataDog · Jun 22, 2022 · 165f5a5 · 165f5a5
1 parent 6d1c0dc
commit 165f5a5
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/contrib/internal/httptrace/httptrace.go b/contrib/internal/httptrace/httptrace.go
@@ -101,13 +101,10 @@ func genClientIPSpanTags(r *http.Request) []ddtrace.StartSpanOption {
 		}
 		return tags
 	}
-	sb := strings.Builder{}
 	for _, hdr := range matches {
 		tags = append(tags, tracer.Tag(ext.HTTPRequestHeaders+"."+hdr, ip))
-		sb.WriteString(hdr + ",")
 	}
-	hdrList := sb.String()
-	tags = append(tags, tracer.Tag(ext.MultipleIPHeaders, hdrList[:len(hdrList)-1]))
+	tags = append(tags, tracer.Tag(ext.MultipleIPHeaders, strings.Join(matches, ",")))
 	return tags
 }