Refactor command-running to run oneshots after startup #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the command-running utilities to take the fx.Options as variadic arguments, so that fxapps.OneShot can add its own fx.Option. It uses a bit of reflection to convince Fx to gather the arguments to a function without actually calling that function immediately, allowing the oneShot function to run after `app.Start` has finished, when we're sure that all components have started. This works around the startup ordering bug in uber-go/fx#918.
|
(somewhat arbitrarily picking you, @juliogreff, for review, just to entice you to look at the repo!) |
This relies on the fix in fx versions >1.18.1 that ensures Invoke's are run in order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the command-running utilities to take the fx.Options as
variadic arguments, so that fxapps.OneShot can add its own fx.Option.
It uses a bit of reflection to convince Fx to gather the arguments to a
function without actually calling that function immediately, allowing
the oneShot function to run after
app.Starthas finished, when we'resure that all components have started. This works around the startup
ordering bug in uber-go/fx#918.