Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workarounds for fx Invoke ordering bug #24

Closed
djmitche opened this issue Aug 22, 2022 · 2 comments
Closed

Remove workarounds for fx Invoke ordering bug #24

djmitche opened this issue Aug 22, 2022 · 2 comments
Assignees
@djmitche

Comments

@djmitche
Copy link
Contributor

uber-go/fx#918 has landed, so let's update to include that version and remove any workarounds made to support it. I don't remember if those workarounds were merged or just in one of my PRs.
@djmitche djmitche self-assigned this Aug 22, 2022
@djmitche
Copy link
Contributor Author

Ah, this was in #23, and the workaround actually makes a bit more sense than depending on Invoke order.

@djmitche
Copy link
Contributor Author

That wasn't really true -- 82b0acf is a great simplification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djmitche djmitche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@djmitche