feature/networking #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 19, 2021 21:39
…tall and npm audit fix.
evamaxfield
reviewed
Aug 23, 2021
evamaxfield
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Looks good to me. @tohuynh should get a change to review though.
tohuynh
approved these changes
Aug 24, 2021
added 2 commits
August 24, 2021 19:57
|
@BrianL3 are you going to try and get the mock firebase into this PR or is this good to go for now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves the primary blocker for creating containers (e.g. most of the remaining work in the front end): a network layer.
Description of Changes
This is nearly purely additive. It adds a NetworkService which in turn will be used by other Services to request and create their appropriate Model objects. A "demo" of how this might work in included in PersonContainer for now.
Link to Forked Storybook Site
https://Brianl3.github.io/cdp-frontend/