Bugfix/change transcript selection to most recent #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Can you add a few things to this PR.
|
|
I am surprised this did not require a re-indexing. Maybe they were already indexed by that property? |
They are! https://github.com/CouncilDataProject/cdp-backend/blob/main/cdp_backend/database/models.py#L559 |
evamaxfield
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
#256
Description of Changes
Change ordering of transcripts to created timestamp in descending order.
Link to Forked Storybook Site
I changed my branch to point at production's config and I can confirm that the transcripts have changed. Does it look to be the correct one?
https://jonlin14.github.io/cdp-frontend/#/events/efb9560456b1
https://councildataproject.org/seattle/#/events/efb9560456b1
Also, I published the page with the config change to point to production but I didn't commit that change. Let me know if I should include it or not.