feature/matter-page #222

BrianL3 · 2022-05-12T00:13:30Z

Link to Relevant Issue

This pull request resolves #56

Description of Changes

This creates the matters/:id route and corresponding page. Everywhere a matter is referenced or discussed (a Person's legislation history, a meeting votes table, an event page) there should now be a link to the associated matter.

Link to Forked Storybook Site

The site

…tter to the appropriate matter page.

evamaxfield · 2022-05-12T00:35:18Z

Wooooooo! So excited and already loving having this available even in brians fork 😂

I got some comments and I haven't looked at the code yet so if there are answers in the code that I should be aware of, just ignore me:

How are sponsors of matters determined? For the ones I have checked there is only ever 1 sponsor but I know that matters can have many sponsors.
Nitpick maybe, but why have multiple status icons?
When I expand the latest vote, there should be details about "Click to expand" to see full voting record. Not sure what text should go there but something should inform the user that they can see the full vote details.
In the "history" part, can we place the meeting date and the body as the first text:

I.e.

* "Full Council -- May 10, 2022"
  "Votes >"
  "Documents >"
* "Transportation Committee -- May 1, 2022"
  "Votes >"
  "Documents >"

Similarly, because we aren't currently storing what the vote was for (tabling, passage to full council, passage of full council, etc.) I actually think we may want to remove the "Adopted" / markers from each history point.
Similarly, the votes in the history should have some text saying "expand" or something
Question for all of us.... are we duplicating data / did we get the logic of minutes item documents and matter documents wrong on the backend or is it frontend?

Two different events have the same attachments.

evamaxfield · 2022-05-12T00:35:51Z

Also, I think cc @NeelApte if you want to follow review process

src/pages/MatterPage/MatterPage.tsx

tohuynh

Thanks for getting this done. Overall, it looks great.

I have a few asks that I think would improve the page a bit.

src/components/Details/Legislation/LegislationOverview.tsx

src/containers/MatterContainer/MatterContainer.tsx

src/containers/PersonContainer/MattersSponsored.tsx

src/networking/MatterStatusService.ts

tohuynh · 2022-05-13T22:29:44Z

src/pages/MatterPage/MatterPage.tsx

+    const matterSponsors = await matterSponsorService.getMatterSponsorByMatterId(id);
+    const sponsors = matterSponsors
+      .filter((matterSponsor) => {
+        return matterSponsor.person;
+      })
+      .map((matterSponsor) => {
+        return matterSponsor.person as Person;
+      });
+
+    const matterStatuses = await matterStatusService.getMatterStatusesByMatterId(id);


Could we group lines 41 and 50 into one Promise.all so that these two pieces of data are fetched concurrently. It will speed up the load of the page by a little.

src/pages/MatterPage/MatterPage.tsx

tohuynh · 2022-05-13T22:54:51Z

Nitpick maybe, but why have multiple status icons?

It was in the wireframes. I'm OK with removing one of the status icons. But if we add vertical spacing between each sub components, it would help?

Similarly, the votes in the history should have some text saying "expand" or something

I think the triangle next to Votes is a common UI pattern used to indicate something is an accordion -- that is there are some more details if clicked on. Though the inconsistency between the triangle next to Votes and the + sign next to See Documents sucks. Maybe make them both have triangles or +s?

Question for all of us.... are we duplicating data / did we get the logic of minutes item documents and matter documents wrong on the backend or is it frontend?

I think it could be backend. The list of files fetched here, just fetch for the files by the event_minutes_item.id. It could also be that the two matter statuses' event_minutes_item_ref point to the same event_minutes_item. Or that the two matter status are the same.

evamaxfield · 2022-05-13T23:03:01Z

I think the triangle next to Votes is a common UI pattern used to indicate something is an accordion -- that is there are some more details if clicked on. Though the inconsistency between the triangle next to Votes and the + sign next to See Documents sucks. Maybe make them both have triangles or +s?

This is good in regards to consistency between the two but I am talking about expanding to each voting bar to reveal the individual votes for that "bar".

I think it could be backend. The list of files fetched here, just fetch for the files by the event_minutes_item.id. It could also be that the two matter statuses' event_minutes_item_ref point to the same event_minutes_item. Or that the two matter status are the same.

I will have to think on this a bunch and figure out what is going wrong.

tohuynh · 2022-05-13T23:06:04Z

I am talking about expanding to each voting bar to reveal the individual votes for that "bar".

Oh, I see. I agree then. Let's save that for another PR to improve the LatestVote and LegislationHistory components.

tohuynh

Thanks for making the changes. Looks good to me, merge whenever.

Brian Ledbetter added 2 commits May 11, 2022 16:52

Created a matter status page.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

fba8861

BrianL3 changed the title ~~Feature/matter page~~ feature/matter-page May 12, 2022

evamaxfield requested review from tohuynh and evamaxfield May 12, 2022 00:23

evamaxfield added the enhancement label May 12, 2022

evamaxfield requested a review from nathankim137311 May 12, 2022 00:23

evamaxfield reviewed May 12, 2022

View reviewed changes

src/pages/MatterPage/MatterPage.tsx Outdated Show resolved Hide resolved

tohuynh reviewed May 13, 2022

View reviewed changes

tohuynh linked an issue May 13, 2022 that may be closed by this pull request

[f_legislationtracking] Design & Web App: Legislation Page #56

Closed

Brian Ledbetter added 2 commits June 7, 2022 12:54

MR feedback

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

36c9814

Merging from main

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

09a174a

tohuynh self-requested a review June 7, 2022 20:27

tohuynh approved these changes Jun 7, 2022

View reviewed changes

BrianL3 merged commit 7ee8245 into CouncilDataProject:main Jun 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/matter-page #222

feature/matter-page #222

BrianL3 commented May 12, 2022 •

edited by tohuynh

Loading

evamaxfield commented May 12, 2022

evamaxfield commented May 12, 2022

tohuynh left a comment

tohuynh May 13, 2022

tohuynh commented May 13, 2022

evamaxfield commented May 13, 2022

tohuynh commented May 13, 2022 •

edited

Loading

tohuynh left a comment

feature/matter-page #222

feature/matter-page #222

Conversation

BrianL3 commented May 12, 2022 • edited by tohuynh Loading

Link to Relevant Issue

Description of Changes

Link to Forked Storybook Site

evamaxfield commented May 12, 2022

evamaxfield commented May 12, 2022

tohuynh left a comment

Choose a reason for hiding this comment

tohuynh May 13, 2022

Choose a reason for hiding this comment

tohuynh commented May 13, 2022

evamaxfield commented May 13, 2022

tohuynh commented May 13, 2022 • edited Loading

tohuynh left a comment

Choose a reason for hiding this comment

BrianL3 commented May 12, 2022 •

edited by tohuynh

Loading

tohuynh commented May 13, 2022 •

edited

Loading