feature/matter-page

[BrianL3]

Link to Relevant Issue

This pull request resolves #56

Description of Changes

This creates the matters/:id route and corresponding page. Everywhere a matter is referenced or discussed (a Person's legislation history, a meeting votes table, an event page) there should now be a link to the associated matter.

Link to Forked Storybook Site

The site

[evamaxfield]

Wooooooo! So excited and already loving having this available even in brians fork 😂

I got some comments and I haven't looked at the code yet so if there are answers in the code that I should be aware of, just ignore me:

1. How are sponsors of matters determined? For the ones I have checked there is only ever 1 sponsor but I know that matters can have many sponsors.
2. Nitpick maybe, but why have multiple status icons?
   
3. When I expand the latest vote, there should be details about "Click to expand" to see full voting record. Not sure what text should go there but something should inform the user that they can see the full vote details.
4. In the "history" part, can we place the meeting date and the body as the first text:
   

I.e.

* "Full Council -- May 10, 2022"
  "Votes >"
  "Documents >"
* "Transportation Committee -- May 1, 2022"
  "Votes >"
  "Documents >"

5. Similarly, because we aren't currently storing what the vote was for (tabling, passage to full council, passage of full council, etc.) I actually think we may want to remove the "Adopted" / markers from each history point.
6. Similarly, the votes in the history should have some text saying "expand" or something
7. Question for all of us.... are we duplicating data / did we get the logic of minutes item documents and matter documents wrong on the backend or is it frontend?
   

Two different events have the same attachments.

[evamaxfield]

Also, I think cc @NeelApte if you want to follow review process

[tohuynh]

Thanks for getting this done. Overall, it looks great.

I have a few asks that I think would improve the page a bit.

[tohuynh]

Could we group lines 41 and 50 into one Promise.all so that these two pieces of data are fetched concurrently. It will speed up the load of the page by a little.

[tohuynh]

Nitpick maybe, but why have multiple status icons?

It was in the wireframes. I'm OK with removing one of the status icons. But if we add vertical spacing between each sub components, it would help?

Similarly, the votes in the history should have some text saying "expand" or something

I think the triangle next to Votes is a common UI pattern used to indicate something is an accordion -- that is there are some more details if clicked on. Though the inconsistency between the triangle next to Votes and the + sign next to See Documents sucks. Maybe make them both have triangles or +s?

Question for all of us.... are we duplicating data / did we get the logic of minutes item documents and matter documents wrong on the backend or is it frontend?

I think it could be backend. The list of files fetched here, just fetch for the files by the event_minutes_item.id. It could also be that the two matter statuses' event_minutes_item_ref point to the same event_minutes_item. Or that the two matter status are the same.

[evamaxfield]

I think the triangle next to Votes is a common UI pattern used to indicate something is an accordion -- that is there are some more details if clicked on. Though the inconsistency between the triangle next to Votes and the + sign next to See Documents sucks. Maybe make them both have triangles or +s?

This is good in regards to consistency between the two but I am talking about expanding to each voting bar to reveal the individual votes for that "bar".

I think it could be backend. The list of files fetched here, just fetch for the files by the event_minutes_item.id. It could also be that the two matter statuses' event_minutes_item_ref point to the same event_minutes_item. Or that the two matter status are the same.

I will have to think on this a bunch and figure out what is going wrong.

[tohuynh]

I am talking about expanding to each voting bar to reveal the individual votes for that "bar".

Oh, I see. I agree then. Let's save that for another PR to improve the LatestVote and LegislationHistory components.

[tohuynh]

Thanks for making the changes. Looks good to me, merge whenever.